Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(explorer): delete linked value action #711

Merged
merged 4 commits into from
Jan 17, 2025
Merged

feat(explorer): delete linked value action #711

merged 4 commits into from
Jan 17, 2025

Conversation

evoiron
Copy link
Collaborator

@evoiron evoiron commented Jan 16, 2025

Checklist

Definition Of Review

  • Own code review done (add notes for others)
  • Write message in teams channel 
     <Title>

*️⃣ Impacted projects : Core - DataStudio - Admin - @leav/ui - @leav/utils - ...

📖 Ticket: https://aristid.atlassian.net/browse/<JIRA_TICKET_IDENTIFIER>

🧑‍💻 PR: <link to PR/MR>

ℹ Info: <brief explanation - context - how to test>

Definition Of Mergeable

  • 2 approves
  • 1 functional review - US has been tested
  • Every comment is handled - blocking ones have been resolved by reviewer
  • Design OK
  • Can be tested by POs
  • PR was introduced during daily meeting

@TdyP
Copy link
Contributor

TdyP commented Jan 16, 2025

Il faudrait changer le libellé du bouton également
image

@NicoSourimant NicoSourimant merged commit 67cd90e into develop Jan 17, 2025
26 checks passed
@NicoSourimant NicoSourimant deleted the feature/XSTREAM-1090_deleteLink branch January 17, 2025 15:40
renaudAmsellem pushed a commit that referenced this pull request Jan 27, 2025
@evoiron @renaudAmsellem
feat(explorer): delete linked value action (#711)
1670956
renaudAmsellem pushed a commit that referenced this pull request Jan 27, 2025
@evoiron @renaudAmsellem
feat(explorer): delete linked value action (#711)
df0a4ff
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NicoSourimant NicoSourimant NicoSourimant approved these changes

@TdyP TdyP TdyP approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@evoiron @TdyP @NicoSourimant