Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for 'include' directives added #28

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

takeshixx
Copy link

This update allows ngxtop to parse files that are included in the Nginx config via 'include' directives. Useful for large deployments where each vhost is located in a separate config file like:

include /usr/local/www/conf/*.conf;

@lebinh
Copy link
Owner

lebinh commented Apr 1, 2014

Thanks, support for include directive would be very helpful indeed. However I think you missed some complications with current implementation:

  • The included file can have other include directives
  • The include file can be specified as relative path to the main nginx config

@takeshixx
Copy link
Author

It was just a quick fix to make ngxtop run on my reverse proxy setup. I'll may fix those two issues in the next few days.

@lostsnow
Copy link

+1

@oxr463
Copy link

oxr463 commented Apr 12, 2020

Merged: ngxtop@f095603

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants