Skip to content

Commit

Permalink
tools/elfutils: simplify and cleanup Makefile
Browse files Browse the repository at this point in the history
After changes to default host build recipes
and default variable definitions,
several custom definitions can be removed,
and the gnulib recipes replaced
with hooks to common recipes.

Also remove leftover PKG_INSTALL
which has no effect for host builds.

Signed-off-by: Michael Pratt <[email protected]>
Link: openwrt/openwrt#15853
Signed-off-by: Robert Marko <[email protected]>
  • Loading branch information
mcprat authored and robimarko committed Jul 8, 2024
1 parent b07099a commit 3b3a81f
Showing 1 changed file with 2 additions and 17 deletions.
19 changes: 2 additions & 17 deletions tools/elfutils/Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -15,12 +15,10 @@ PKG_LICENSE_FILES:=COPYING COPYING-GPLV2 COPYING-LGPLV3
PKG_CPE_ID:=cpe:/a:elfutils_project:elfutils

PKG_FIXUP:=autoreconf
PKG_INSTALL:=1

PKG_PROGRAMS:=elflint findtextrel elfcmp unstrip stack elfcompress elfclassify srcfiles

PKG_SUBDIRS := \
libgnu \
config \
lib \
libelf \
Expand All @@ -36,8 +34,6 @@ PKG_GNULIB_BASE:=libgnu

PKG_GNULIB_ARGS = \
--dir=$(HOST_BUILD_DIR) \
--local-dir=$(STAGING_DIR_HOST)/share/gnulib \
--source-base=$(PKG_GNULIB_BASE) \
--libtool \
--avoid=reallocarray \
--import
Expand Down Expand Up @@ -74,7 +70,6 @@ ifeq ($(HOST_OS),Darwin)
endif

HOST_CFLAGS += -Wno-error -fPIC
HOST_CXXFLAGS += -O2

HOST_CONFIGURE_ARGS += \
--without-libintl-prefix \
Expand All @@ -98,18 +93,8 @@ HOST_CONFIGURE_VARS += \
ac_cv_search__obstack_free=yes \
ac_cv_buildid=yes

Hooks/HostConfigure/Pre := Host/Gnulib $(Hooks/HostConfigure/Pre)
define Host/Gnulib
$(STAGING_DIR_HOST)/bin/gnulib-tool $(PKG_GNULIB_ARGS) $(PKG_GNULIB_MODS);
endef

define Host/Compile
$(call Host/Compile/Default,SUBDIRS='$$$$(wildcard $(PKG_SUBDIRS))')
endef

define Host/Install
$(call Host/Compile/Default,install SUBDIRS='$$$$(wildcard $(PKG_SUBDIRS))')
endef
Hooks/HostConfigure/Pre := Host/Gnulib/Prepare $(Hooks/HostConfigure/Pre)
Hooks/HostCompile/Pre := Host/Gnulib/Compile $(Hooks/HostCompile/Pre)

define Host/Uninstall
-$(call Host/Compile/Default,uninstall)
Expand Down

0 comments on commit 3b3a81f

Please sign in to comment.