Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Merging of the realtek 6.6 series forgot to include some final fixes for the new MDIO driver. What was changed in last second? 1. The MDIO driver used wrong constants to make use of the raw page (for direct register access). Provide a rawpage variable in the bus private structure, populate it during initialization and make use of it at the proper places 2. We always used the variable portaddr for the bus index. Usually our driver uses either addr or port for the same meaning. Remove the duplication and reuse the normal addr variable. 3. Drop functions rtmdio_write_page() and rtmdio_read_page(). These only call the PHY driver read/write page functions. We know that these will only access page 0x1f. As we have only Realtek PHYs and our driver only reacts to this special page, just hardcode it. Benefit is that we can use these functions for PHY detection when read/write page functions are not yet assigned. 4. Add two new helper functions phy_port_read_paged() and phy_port_write_paged(). These allow to access arbitrary ports on the MDIO bus when the packages are not initialized. These will be needed for proper RTL8218B and RTL8214FC detection in forthcoming patches. 5. The port tracking wrongly used index 0 to mark "normal" access. This does not allow to make a "special" access to port 0. Use index -1 to mark "normal" access. Provide the fix for 5.15 and 6.6 to allow for easy version comparison. Signed-off-by: Markus Stockhausen <[email protected]> Link: openwrt/openwrt#16391 Signed-off-by: Robert Marko <[email protected]>
- Loading branch information