Merge pull request #7793 from ehuelsmann/fix/master/1.3-migrations

More 1.3 migration fixes
ledgersmb · Dec 9, 2023 · 3934e1a · 3934e1a
2 parents a846aa1 + 77b0dff
commit 3934e1a
Show file tree

Hide file tree

Showing 2 changed files with 213 additions and 146 deletions.
diff --git a/lib/LedgerSMB/Upgrade_Tests.pm b/lib/LedgerSMB/Upgrade_Tests.pm
@@ -653,17 +653,20 @@ push @tests, __PACKAGE__->new(
 );
 
 push @tests, __PACKAGE__->new(
-   test_query => q{select distinct gifi_accno from account
+   test_query => q{select distinct gifi_accno as accno from account
                    where not exists (select 1
                                        from gifi
                                       where gifi.accno = account.gifi_accno)
                          and gifi_accno is not null
                          and gifi_accno !~ '^\s*$'},
  display_name => marktext('GIFI accounts not in "gifi" table'),
          name => 'missing_gifi_table_rows',
- display_cols => [ 'gifi_accno' ],
-        table => 'account',
- instructions => marktext('Please use the 1.3 UI to add the GIFI accounts'),
+ display_cols => [ 'accno', 'description' ],
+        table => 'gifi',
+       insert => 1,
+      columns => ['description'],
+   id_columns => ['accno'],
+ instructions => marktext('Please add the missing GIFI accounts'),
       appname => 'ledgersmb',
   min_version => '1.3',
   max_version => '1.3'