Fix encoding of the column data, including col_id #7745
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Due to the fact that all column data was encoded for output-format-safety, the CoA and Trial Balance reports didn't show some columns in PDF format (with LaTeX intermediate representation). The column *keys* in the ROW data do *not* get encoded, whereas the column keys (stored in the column data as values) *do* get encoded. Due to this mismatch, the column name 'credit_balance' differed between the row data and the column data (the latter containing the encoded value 'credit\_balance'). Fixes ledgersmb#7739.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to the fact that all column data was encoded for output-format-safety, the CoA and Trial Balance reports didn't show some columns in PDF format (with LaTeX intermediate representation). The column keys in the ROW data do not get encoded, whereas the column keys (stored in the column data as values) do get encoded. Due to this mismatch, the column name 'credit_balance' differed between the row data and the column data (the latter containing the encoded value 'credit_balance').
Fixes #7739.