Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Additional functionality #127

Draft
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

Cyberhan123
Copy link
Contributor

@Cyberhan123 Cyberhan123 commented Dec 27, 2023

I want to add functionality to our current library, Do you have any suggestions? @leejet @FSSRepo

  • Add custom log output callback
  • Add termination logic during image generation
  • Other models can be reloaded

@Cyberhan123
Copy link
Contributor Author

SDLogLevel::ERROR conflicts with the windows macro ERROR

@Jonathhhan
Copy link

SDLogLevel::ERROR conflicts with the windows macro ERROR

Not a very elegant solution, but in earlier versions (when it was part of stable-diffusion.cpp/.h) I replaced it with SDLogLevel::SD_ERROR.

@Cyberhan123
Copy link
Contributor Author

Cyberhan123 commented Dec 30, 2023

SDLogLevel::ERROR conflicts with the windows macro ERROR

Not a very elegant solution, but in earlier versions (when it was part of stable-diffusion.cpp/.h) I replaced it with SDLogLevel::SD_ERROR.

But this is the most practical solution. If we keep the original ERROR writing method, there will be bugs in set_sd_log_level on Windows.

I was also shocked. SETLogLevel::ERROR made me feel that it was in the scope SDLogLevel at first. In fact, it exists globally and is equivalent to ERROR.

@Cyberhan123
Copy link
Contributor Author

The latest code has achieved my needs

@Cyberhan123 Cyberhan123 closed this Jan 2, 2024
@Cyberhan123 Cyberhan123 reopened this Jan 2, 2024
@Cyberhan123
Copy link
Contributor Author

Cyberhan123 commented Jan 2, 2024

Sorry, I think I missed the thing about pretty_progress integration sd_set_log_callback, so that we can log progress in GUI, so I need to reopen pr to implement it

@Cyberhan123
Copy link
Contributor Author

This is not an urgent matter at the moment, I'll move it to a draft

@Cyberhan123 Cyberhan123 marked this pull request as draft January 18, 2024 11:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants