Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature - save sorting options #441

Open
pbogre opened this issue Jul 26, 2023 · 8 comments · May be fixed by #451
Open

feature - save sorting options #441

pbogre opened this issue Jul 26, 2023 · 8 comments · May be fixed by #451
Labels
enhancement New feature or request

Comments

@pbogre
Copy link
Collaborator

pbogre commented Jul 26, 2023

when i go to the 'all movies' section it automatically sorts them in alphabetical order, and when i set the options so that it sorts by rating in descending order it works fine, however i would like this option to persist even after i leave the page.

maybe this could be done with a 'default sorting' option in the settings, but if that is set to 'sort by rating' it falls back to alphabetical sort for categories that don't have ratings. or save the sorting preference for each page.

@pbogre pbogre changed the title save sorting options feature - save sorting options Jul 26, 2023
@leepeuker leepeuker added the enhancement New feature or request label Jul 26, 2023
@pbogre pbogre linked a pull request Jul 27, 2023 that will close this issue
@leepeuker
Copy link
Owner

leepeuker commented Jul 27, 2023

Hm, I am not sure if the the options should be saved, at least by default. I would not expect an app to keep my save sorting options persistent, or that I even really wanted that.
What about this: We add a save icon at the right end of the search option inputs. You can press it to save this individual option. This way it would be optional to remember options and you can control what you save pretty well.

By the way, I do not really like how the options look in general
image
this does not look really nice. I was thinking about replacing the dropdown with a modal or something in that direction. suggestions are welcome

@pbogre
Copy link
Collaborator Author

pbogre commented Jul 27, 2023

i see, in that case you're right it might be wise to add a 'save' button.

regarding the UI i didn't make any changes, and it looks the same as it did before the change to me, so that's odd. are you referring to the width of the sorting order option? i did not design any of the modal so i tried to keep it the same

edit: oh do you mean that the options modal should be changed in general? we could make a new issue for that

@leepeuker
Copy link
Owner

Yeah I know you did not make any UI changes, I just wanted to say that I am open to completely redesigning this, so how or where to save does not necessarily have to be bound to it.

@leepeuker
Copy link
Owner

I have created dummy search options modal see here: #455

image

I think I like this better than before 🤔

@pbogre
Copy link
Collaborator Author

pbogre commented Jul 29, 2023

looks really good! only thing is having a whole line for the sorting order, which feels like a lot when you use an icon as the options. you could change it so instead of icons the options are 'ascending' and 'descending'

@pbogre
Copy link
Collaborator Author

pbogre commented Jul 29, 2023

reminder to self: add button 'Set as Default' to advanced search modal and set cookies on click there instead of in MoviesController.php, ActorsController.php, DirectorsController.php

@leepeuker
Copy link
Owner

FYI I will update the person search pages too with the new modal UI

@pbogre
Copy link
Collaborator Author

pbogre commented Jul 29, 2023

that's perfect i was just about to comment that to apply the latest changes (save sorting button) to people as well i need a modal for actors/directors too. thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants