-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feature - save sorting options #441
Comments
i see, in that case you're right it might be wise to add a 'save' button. regarding the UI i didn't make any changes, and it looks the same as it did before the change to me, so that's odd. are you referring to the width of the sorting order option? i did not design any of the modal so i tried to keep it the same edit: oh do you mean that the options modal should be changed in general? we could make a new issue for that |
Yeah I know you did not make any UI changes, I just wanted to say that I am open to completely redesigning this, so how or where to save does not necessarily have to be bound to it. |
I have created dummy search options modal see here: #455 I think I like this better than before 🤔 |
looks really good! only thing is having a whole line for the sorting order, which feels like a lot when you use an icon as the options. you could change it so instead of icons the options are 'ascending' and 'descending' |
reminder to self: add button 'Set as Default' to advanced search modal and set cookies on click there instead of in |
FYI I will update the person search pages too with the new modal UI |
that's perfect i was just about to comment that to apply the latest changes (save sorting button) to people as well i need a modal for actors/directors too. thanks |
when i go to the 'all movies' section it automatically sorts them in alphabetical order, and when i set the options so that it sorts by rating in descending order it works fine, however i would like this option to persist even after i leave the page.
maybe this could be done with a 'default sorting' option in the settings, but if that is set to 'sort by rating' it falls back to alphabetical sort for categories that don't have ratings. or save the sorting preference for each page.
The text was updated successfully, but these errors were encountered: