-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Save sorting options using cookies #451
base: main
Are you sure you want to change the base?
Conversation
reminder: create & use save sorting button for people too once a search option modal is implemented |
@leepeuker all set with the new modal ui! feel free to take a look using latest commit |
There are a few things I would like to adjust:
|
i agree about using the backend and not cookies for the preferences. maybe a new column in the user settings database? the options shouldn't be saved automatically in the latest commit. unless you click the button that saves them they shouldn't persist next time you load the page, and if they do that's a bug that i need to fix :) i'm not sure about saving other options like filters, because that's not really something that people would want to persist on a long term basis, while sorting options might |
use cookies to save sorting options for movies and people.
the cookies are set to last 1 year and are based in "/", here's what an example looks like:
'movie-sort-order' = 'desc'
'movie-sort-by' = 'name'
'person-sort-order' = 'asc'
'person-sort-by' = 'uniqueAppearances'
closes #441