-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rework docker image #542
Draft
leepeuker
wants to merge
3
commits into
main
Choose a base branch
from
docker-rework
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Rework docker image #542
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,4 +1,3 @@ | ||
build/ | ||
tests/ | ||
public/images/cached/* | ||
tmp/* |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,76 @@ | ||
############## | ||
# Base image # | ||
############## | ||
FROM alpine:3.18 as base | ||
|
||
WORKDIR /app | ||
|
||
RUN apk add --no-cache \ | ||
curl \ | ||
nano \ | ||
nginx \ | ||
php82 \ | ||
php82-ctype \ | ||
php82-curl \ | ||
php82-dom \ | ||
php82-fileinfo \ | ||
php82-fpm \ | ||
php82-gd \ | ||
php82-intl \ | ||
php82-json \ | ||
php82-mbstring \ | ||
php82-mysqli \ | ||
php82-opcache \ | ||
php82-openssl \ | ||
php82-pdo_mysql \ | ||
php82-phar \ | ||
php82-session \ | ||
php82-simplexml \ | ||
php82-tokenizer \ | ||
php82-xml \ | ||
php82-xmlreader \ | ||
php82-xmlwriter \ | ||
supervisor | ||
|
||
# Configure nginx | ||
COPY build/config/nginx.conf /etc/nginx/nginx.conf | ||
COPY build/config/conf.d /etc/nginx/conf.d/ | ||
|
||
# Configure PHP-FPM | ||
ENV PHP_INI_DIR /etc/php82 | ||
COPY build/config/fpm-pool.conf ${PHP_INI_DIR}/php-fpm.d/www.conf | ||
COPY build/config/php.ini ${PHP_INI_DIR}/conf.d/custom.ini | ||
|
||
# Configure supervisord | ||
COPY build/config/supervisord.conf /etc/supervisor/conf.d/supervisord.conf | ||
|
||
# Make sure files/folders needed by the processes are accessable when they run under the nobody user | ||
RUN chown -R nobody.nobody /app /run /var/lib/nginx /var/log/nginx | ||
|
||
# Create symlink for php | ||
RUN ln -s /usr/bin/php82 /usr/bin/php | ||
|
||
# Install composer from the official image | ||
COPY --from=composer /usr/bin/composer /usr/bin/composer | ||
|
||
# Switch to use a non-root user from here on | ||
USER nobody | ||
|
||
# Expose the port nginx is reachable on | ||
EXPOSE 8080 | ||
|
||
# Let supervisord start nginx & php-fpm | ||
CMD ["/usr/bin/supervisord", "-c", "/etc/supervisor/conf.d/supervisord.conf"] | ||
|
||
# Configure a healthcheck to validate that everything is up & running | ||
HEALTHCHECK --timeout=10s CMD curl --silent --fail http://127.0.0.1:8080/fpm-ping | ||
|
||
##################### | ||
# Development image # | ||
##################### | ||
FROM base as development | ||
|
||
#################### | ||
# Production image # | ||
#################### | ||
FROM base as production |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,57 @@ | ||
# Default server definition | ||
server { | ||
listen [::]:80 default_server; | ||
listen 80 default_server; | ||
server_name _; | ||
|
||
sendfile off; | ||
tcp_nodelay on; | ||
absolute_redirect off; | ||
|
||
root /app/public; | ||
index index.php index.html; | ||
|
||
location / { | ||
# First attempt to serve request as file, then | ||
# as directory, then fall back to index.php | ||
try_files $uri $uri/ /index.php?q=$uri&$args; | ||
} | ||
|
||
# Redirect server error pages to the static page /50x.html | ||
error_page 500 502 503 504 /50x.html; | ||
location = /50x.html { | ||
root /var/lib/nginx/html; | ||
} | ||
|
||
# Pass the PHP scripts to PHP-FPM listening on php-fpm.sock | ||
location ~ \.php$ { | ||
try_files $uri =404; | ||
fastcgi_split_path_info ^(.+\.php)(/.+)$; | ||
fastcgi_pass unix:/run/php-fpm.sock; | ||
fastcgi_param SCRIPT_FILENAME $document_root$fastcgi_script_name; | ||
fastcgi_param SCRIPT_NAME $fastcgi_script_name; | ||
fastcgi_index index.php; | ||
include fastcgi_params; | ||
} | ||
|
||
# Set the cache-control headers on assets to cache for 5 days | ||
location ~* \.(jpg|jpeg|gif|png|css|js|ico|xml)$ { | ||
expires 5d; | ||
} | ||
|
||
# Deny access to . files, for security | ||
location ~ /\. { | ||
log_not_found off; | ||
deny all; | ||
} | ||
|
||
# Allow fpm ping and status from localhost | ||
location ~ ^/(fpm-status|fpm-ping)$ { | ||
access_log off; | ||
allow 127.0.0.1; | ||
deny all; | ||
fastcgi_param SCRIPT_FILENAME $document_root$fastcgi_script_name; | ||
include fastcgi_params; | ||
fastcgi_pass unix:/run/php-fpm.sock; | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,56 @@ | ||
[global] | ||
; Log to stderr | ||
error_log = /dev/stderr | ||
|
||
[www] | ||
; The address on which to accept FastCGI requests. | ||
; Valid syntaxes are: | ||
; 'ip.add.re.ss:port' - to listen on a TCP socket to a specific IPv4 address on | ||
; a specific port; | ||
; '[ip:6:addr:ess]:port' - to listen on a TCP socket to a specific IPv6 address on | ||
; a specific port; | ||
; 'port' - to listen on a TCP socket to all addresses | ||
; (IPv6 and IPv4-mapped) on a specific port; | ||
; '/path/to/unix/socket' - to listen on a unix socket. | ||
; Note: This value is mandatory. | ||
listen = /run/php-fpm.sock | ||
|
||
; Enable status page | ||
pm.status_path = /fpm-status | ||
|
||
; Ondemand process manager | ||
pm = ondemand | ||
|
||
; The number of child processes to be created when pm is set to 'static' and the | ||
; maximum number of child processes when pm is set to 'dynamic' or 'ondemand'. | ||
; This value sets the limit on the number of simultaneous requests that will be | ||
; served. Equivalent to the ApacheMaxClients directive with mpm_prefork. | ||
; Equivalent to the PHP_FCGI_CHILDREN environment variable in the original PHP | ||
; CGI. The below defaults are based on a server without much resources. Don't | ||
; forget to tweak pm.* to fit your needs. | ||
; Note: Used when pm is set to 'static', 'dynamic' or 'ondemand' | ||
; Note: This value is mandatory. | ||
pm.max_children = 100 | ||
|
||
; The number of seconds after which an idle process will be killed. | ||
; Note: Used only when pm is set to 'ondemand' | ||
; Default Value: 10s | ||
pm.process_idle_timeout = 10s; | ||
|
||
; The number of requests each child process should execute before respawning. | ||
; This can be useful to work around memory leaks in 3rd party libraries. For | ||
; endless request processing specify '0'. Equivalent to PHP_FCGI_MAX_REQUESTS. | ||
; Default Value: 0 | ||
pm.max_requests = 1000 | ||
|
||
; Make sure the FPM workers can reach the environment variables for configuration | ||
clear_env = no | ||
|
||
; Catch output from PHP | ||
catch_workers_output = yes | ||
|
||
; Remove the 'child 10 said into stderr' prefix in the log and only show the actual message | ||
decorate_workers_output = no | ||
|
||
; Enable ping page to use in healthcheck | ||
ping.path = /fpm-ping |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,45 @@ | ||
worker_processes auto; | ||
error_log stderr warn; | ||
pid /run/nginx.pid; | ||
|
||
events { | ||
worker_connections 1024; | ||
} | ||
|
||
http { | ||
include mime.types; | ||
default_type application/octet-stream; | ||
|
||
# Define custom log format to include reponse times | ||
log_format main_timed '$remote_addr - $remote_user [$time_local] "$request" ' | ||
'$status $body_bytes_sent "$http_referer" ' | ||
'"$http_user_agent" "$http_x_forwarded_for" ' | ||
'$request_time $upstream_response_time $pipe $upstream_cache_status'; | ||
|
||
access_log /dev/stdout main_timed; | ||
error_log /dev/stderr notice; | ||
|
||
keepalive_timeout 65; | ||
|
||
# Write temporary files to /tmp so they can be created as a non-privileged user | ||
client_body_temp_path /tmp/client_temp; | ||
proxy_temp_path /tmp/proxy_temp_path; | ||
fastcgi_temp_path /tmp/fastcgi_temp; | ||
uwsgi_temp_path /tmp/uwsgi_temp; | ||
scgi_temp_path /tmp/scgi_temp; | ||
|
||
# Hardening | ||
proxy_hide_header X-Powered-By; | ||
fastcgi_hide_header X-Powered-By; | ||
server_tokens off; | ||
|
||
# Enable gzip compression by default | ||
gzip on; | ||
gzip_proxied any; | ||
gzip_types text/plain application/xml text/css text/js text/xml application/x-javascript text/javascript application/json application/xml+rss; | ||
gzip_vary on; | ||
gzip_disable "msie6"; | ||
|
||
# Include server configs | ||
include /etc/nginx/conf.d/*.conf; | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,3 @@ | ||
[Date] | ||
date.timezone="UTC" | ||
expose_php= Off |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,35 @@ | ||
[supervisord] | ||
nodaemon=true | ||
logfile=/dev/null | ||
logfile_maxbytes=0 | ||
pidfile=/run/supervisord.pid | ||
|
||
[program:php-fpm] | ||
command=php-fpm82 -F | ||
stdout_logfile=/dev/stdout | ||
stdout_logfile_maxbytes=0 | ||
stderr_logfile=/dev/stderr | ||
stderr_logfile_maxbytes=0 | ||
autorestart=false | ||
startretries=0 | ||
|
||
[program:nginx] | ||
command=nginx -g 'daemon off;' | ||
stdout_logfile=/dev/stdout | ||
stdout_logfile_maxbytes=0 | ||
stderr_logfile=/dev/stderr | ||
stderr_logfile_maxbytes=0 | ||
autorestart=false | ||
startretries=0 | ||
|
||
[program:movary] | ||
command=php /app/bin/console.php jobs:process | ||
numprocs=1 | ||
autostart=true | ||
autorestart=true | ||
startsecs=1 | ||
startretries=10 | ||
stdout_logfile=/dev/stdout | ||
stdout_logfile_maxbytes=0 | ||
stderr_logfile=/dev/stderr | ||
stderr_logfile_maxbytes=0 |
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
when
USER_ID
is changed the container does not work anymore because e.g. supervisor cannot be started.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does that matter? I think the most important part is to ensure that the container doesn't run as root, due to security concerns.