-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add authentication check endpoint #582
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BTW, the reason that I think this endpoint is necesssary, is because there's currently no way for the new Vue frontend to figure out whether the user is authenticated or not. Additionally, if the user was authenticated, the frontend still can't figure out which user is authenticated. |
74 tasks
JVT038
force-pushed
the
add-authentication-check-endpoint
branch
from
February 25, 2024 20:43
6d34481
to
540e7a6
Compare
leepeuker
reviewed
Feb 27, 2024
leepeuker
reviewed
Feb 27, 2024
leepeuker
reviewed
Feb 27, 2024
leepeuker
reviewed
Feb 27, 2024
Signed-off-by: JVT038 <[email protected]>
Signed-off-by: JVT038 <[email protected]>
JVT038
commented
Feb 27, 2024
leepeuker
approved these changes
Feb 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds an API endpoint to check if the user is authenticated or not.
The path is
/authentication/authenticated
and it returns a JSON object withauthenticated = false || true
.If the user is authenticated, the object will also include a
username
anduserId
property, with the values of the current username and ID.This PR is based on #575 , so it has to be merged after that one.