-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Revision to Thermo target #61
Open
leeping
wants to merge
31
commits into
master
Choose a base branch
from
thermo2
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hi Lee-Ping, This looks very promising! I will be travelling for a week, but I will Best, |
…liary files (.top, .mdp) and run the simulation.
Conflicts: src/observable.py src/parser.py src/thermo.py studies/004_thermo/single.in
…erry pick over to main).
Conflicts: src/abinitio.py src/observable.py
…mulation settings)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Progress and notes:
DataFrame
.Observable
andSimulation
objects from user input (100% done)solid_density
orliquid_density
Observable
class needs to pass some information to theSimulation
. Need to figure out how to do this right.eq_steps
,md_steps
,timestep
).get_timeseries()
frommolecular_dynamics()
(60% done)DataFrame
.md_chain.py
(i.e. a chain of simulations for a particular index), ormd_one.py
(i.e. independent simulations) (50% done)npt.py
andnpt_lipid.py
md_chain.py
andmd_one.py
use the same file and directory structure? Need to make sure output frommd_one.py
is properly named - or put results frommd_one.py
into different folders.Target
anyway.targets/target_name/system_index/simulation_name_#.[gro|pdb|xyz]
numbered from 1. Multiple files are best because PDB format often doesn't update the periodic box across different structures._#
not needed.md_one.py
andmd_chain.py
should have ways to calculate all observables that they are able to calculate (as an additional way to check consistency)