-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes for Python 3.12 #174
Conversation
Thank you, Ben. I don't see any issue with merging this into master. :) |
Thanks a lot for the recent fixes. Is it possible to use We would need to drop Python 3.7 in the next release if we go this route and I'm okay with that. |
Actually, it's used in one place, to check the version of networkX. The check is to see if networkX is > 2.0, which was released in 2017. It is probably safe to remove that check, since that is a pretty old version now. It's likely if you try to install 2.0 other things will break before geometric does. There's one more thing that likely needs a fix: In the |
If you merge the latest changes from master, the Conda environment should now be set up correctly. |
The tests indicate the optimization log file is not being generated for an OpenMM test. (The other OpenMM tests do not involve parsing the log file). Did the logging behavior change somehow? |
Wow sorry, that's me being sloppy. My latest commit hopefully fixes all those |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The latest changes all look good!
Great! You can probably squash and make this cleaner when you merge |
LGTM! Sounds good regarding the squash, I'll do that. |
The versioneer issue has been resolved for some time, but an old versioneer is vendored here. Upgrade with See https://github.com/python-versioneer/python-versioneer/blob/master/UPGRADING.md for any migration issues. |
* Hacky fixes to versioneer for python 3.12 * Add python 3.11 and 3.12 to GHA tests * Deprecate distutils and add test * Change python version detectino to < 3.8 * rdkit is not 3.12 compatible yet * Remove dependence on pkg_resources * Remove need for packaging/parse_version * Some test fixes
This fixes versioneer to be compatible with python 3.12. This also adds python 3.11 and 3.12 to the Github Actions tests.
The fix to versioneer is somewhat hacky (rather than vendor a new
versioneer.py
from the not-yet-released versioneer package).This also replaces the use of
distutils
innifty
.distutils
was removed in python 3.12 (but is still available from setuptools). Thecopytree
command from distutils (withdirs_exist_ok=True
) should be equivalent for python 3.8+. A test was added for thecopy_tree_over
function.Fixes issue #173