Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add DSP for Muon Veto PMTs #49

Merged
merged 2 commits into from
Jan 24, 2025
Merged

Add DSP for Muon Veto PMTs #49

merged 2 commits into from
Jan 24, 2025

Conversation

MayaMenzel
Copy link
Contributor

I added a new function dsp_pmts which can be used to perform DSP on muon veto PMTs.

@theHenks theHenks requested a review from fhagemann January 24, 2025 15:55
@theHenks theHenks added the enhancement New feature or request label Jan 24, 2025
@theHenks theHenks self-requested a review January 24, 2025 15:56
theHenks
theHenks requested changes Jan 24, 2025
View reviewed changes
Copy link
Collaborator

@theHenks theHenks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor comments.
Also, could you link the PR to the jldataprod-config with the configuration pars here?

src/dsp_pmts.jl Outdated Show resolved Hide resolved
src/dsp_pmts.jl Show resolved Hide resolved
src/dsp_pmts.jl Outdated Show resolved Hide resolved
src/dsp_pmts.jl Outdated Show resolved Hide resolved
@MayaMenzel
Copy link
Contributor Author

Also, could you link the PR to the jldataprod-config with the configuration pars here?

The PR onto jldataprod-config is https://github.com/legend-exp/legend-jldataflow-config/pull/8

theHenks
theHenks approved these changes Jan 24, 2025
View reviewed changes
Copy link
Collaborator

@theHenks theHenks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect, thanks!

@theHenks theHenks merged commit 2047365 into legend-exp:main Jan 24, 2025
7 checks passed
@MayaMenzel MayaMenzel deleted the dsp_pmts branch January 24, 2025 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@theHenks theHenks theHenks approved these changes

@fhagemann fhagemann Awaiting requested review from fhagemann

Assignees

@MayaMenzel MayaMenzel

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MayaMenzel @theHenks