SiPM Optimization
#52
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fhagemann
requested changes
Feb 1, 2025
theHenks
force-pushed
the
sipm-optimization
branch
from
0b2b1a0 to
06626f0
Compare
Welcome to Codecov 🎉Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests. Thanks for integrating Codecov - We've got you covered ☂️ |
fhagemann
approved these changes
Feb 3, 2025
fhagemann
force-pushed
the
sipm-optimization
branch
from
66f7fac to
df4dc89
Compare
|
I rebased this PR to exclude all commits involving using |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New
SiPMoptimization DSP. The function sweeps through different filter lengths and generates the DSP in a grid style.The PR includes also bug fixes for:
dsp_pulssplitted into compressed and not-compressed versionn_thresholdnaming changed toconfig.n_σ_thresholdto adapt to new metadata layoutIncludedStatsBaseas dependency