Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI improvements #100

Merged
merged 27 commits into from
Feb 21, 2025
Merged

CI improvements #100

merged 27 commits into from
Feb 21, 2025

Conversation

gipert
Copy link
Member

@gipert gipert commented Feb 12, 2025

No description provided.

Copy link

codecov bot commented Feb 12, 2025

Codecov Report

Attention: Patch coverage is 30.00000% with 7 lines in your changes missing coverage. Please review.

Project coverage is 43.63%. Comparing base (9d7303a) to head (8961beb).
Report is 28 commits behind head on main.

Files with missing lines Patch % Lines
workflow/src/legenddataflow/execenv.py 16.66% 5 Missing ⚠️
workflow/src/legenddataflow/utils.py 50.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #100      +/-   ##
==========================================
- Coverage   43.66%   43.63%   -0.03%     
==========================================
  Files          17       17              
  Lines        1152     1155       +3     
==========================================
+ Hits          503      504       +1     
- Misses        649      651       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gipert
Copy link
Member Author

gipert commented Feb 12, 2025

@ggmarshall can you spot the problem? If you fix it then it's good to merge. Unfortunately --touch does not touch non-existing files -> that's something we can easily add to the plugin.

But is touching output files smart? Do we code in the Snakefiles that needs to interact with non-dummy outputs?

@gipert gipert marked this pull request as ready for review February 12, 2025 21:33
@gipert
Copy link
Member Author

gipert commented Feb 12, 2025

I have to implement something to make the test output more readable...

@gipert gipert requested a review from ggmarshall February 12, 2025 21:46
@gipert gipert linked an issue Feb 13, 2025 that may be closed by this pull request
@gipert
Copy link
Member Author

gipert commented Feb 20, 2025

@ggmarshall what about now?

@ggmarshall
Copy link
Collaborator

this is tougher to fix as those aren't stored on git, I want to remove them soon

@gipert
Copy link
Member Author

gipert commented Feb 21, 2025

let's just touch them?

@ggmarshall
Copy link
Collaborator

Sure let’s do that for the moment

@ggmarshall
Copy link
Collaborator

I want to remove them eventually though

@gipert
Copy link
Member Author

gipert commented Feb 21, 2025

I'm gonna merge this since tests pass, we can find a way to speed up the thing with a future PR

@gipert gipert merged commit 8a76eea into main Feb 21, 2025
11 checks passed
@gipert gipert deleted the ci branch February 21, 2025 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Test dataprod scripts in CI
2 participants