Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update validity management code to new format #67

Merged
merged 6 commits into from
Nov 26, 2024

Conversation

ggmarshall
Copy link
Collaborator

@ggmarshall ggmarshall commented Nov 25, 2024

@gipert
Copy link
Member

gipert commented Nov 25, 2024

.yaml is more common than .yml, I think. I would propose to stick to that.

src/legendmeta/textdb.py Outdated Show resolved Hide resolved
@ggmarshall ggmarshall marked this pull request as ready for review November 25, 2024 17:32
@gipert
Copy link
Member

gipert commented Nov 26, 2024

can you please update the docs?

@gipert
Copy link
Member

gipert commented Nov 26, 2024

...including adding the essential docstrings to catalog.py?

Copy link

codecov bot commented Nov 26, 2024

Codecov Report

Attention: Patch coverage is 73.17073% with 11 lines in your changes missing coverage. Please review.

Project coverage is 72.02%. Comparing base (838ca85) to head (b460921).
Report is 15 commits behind head on main.

Files with missing lines Patch % Lines
src/legendmeta/catalog.py 78.57% 6 Missing ⚠️
src/legendmeta/police.py 16.66% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #67      +/-   ##
==========================================
+ Coverage   71.95%   72.02%   +0.06%     
==========================================
  Files           8        8              
  Lines         813      840      +27     
==========================================
+ Hits          585      605      +20     
- Misses        228      235       +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gipert gipert changed the title update validity files to new format Update validity management code to new format Nov 26, 2024
@gipert gipert linked an issue Nov 26, 2024 that may be closed by this pull request
@gipert gipert merged commit c7cb940 into legend-exp:main Nov 26, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement parsing of new validity file format
2 participants