Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

output: swap ntuple group name and ntuple name #269

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

output: swap ntuple group name and ntuple name #269

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 14 additions & 8 deletions src/RMGConvertLH5.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -264,7 +264,7 @@ bool RMGConvertLH5::ConvertToLH5Internal() {

H5::H5File hfile(fHdf5FileName, H5F_ACC_RDWR, H5::FileCreatPropList::DEFAULT, fapl);

auto ntuple_group_name = fNtupleGroupName;
const auto ntuple_group_name = fNtupleGroupName;

// check that this file has been written by geant4/remage, and that we did not run this upgrade
// script before (it will delete the header group below).
Expand All @@ -284,18 +284,24 @@ bool RMGConvertLH5::ConvertToLH5Internal() {
// rework the ntuples to LGDO tables.
auto ntuples_group = hfile.openGroup(ntuple_group_name);
auto ntuples = GetChildren(ntuples_group);
for (const auto& ntuple : ntuples) {
if (hfile.nameExists(ntuple)) {
LH5Log(RMGLog::error, "top-level object already exists: ", ntuple);
return false;
}
}
bool ntuple_success = true;
for (auto& ntuple : ntuples) {
for (const auto& ntuple : ntuples) {
auto det_group = ntuples_group.openGroup(ntuple);
ntuple_success &= ConvertNTupleToTable(det_group);
}
// make the root HDF5 group an LH5 struct.
if (!ntuples_group.attrExists("datatype")) {
SetStringAttribute(ntuples_group, "datatype",
"struct{" + fmt::format("{}", fmt::join(ntuples, ",")) + "}");
det_group.close();
// move ntuple one level up.
hfile.createGroup(ntuple);
hfile.moveLink(ntuple_group_name + "/" + ntuple, ntuple + "/" + ntuple_group_name);
}

if (ntuples_group.attrExists("type")) ntuples_group.removeAttr("type");
ntuples_group.close();
hfile.unlink(ntuple_group_name);

// check other things that geant4 might write into the file, and delete them if they are empty.
if (ExistsByType(hfile, "default_histograms", H5O_TYPE_GROUP)) {
Expand Down
Loading