-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[2.0] Improve Testing Coverage #419
Conversation
Coverage Report
|
…e get datastreams to singular
… poll and publish during async init
…nc vs async in gateway
…stants, remove extra testing classes
… should remove the error handling; remove device area fallback; change geofields to using an array; fix unit_of_measurement
@legrego I believe I am done with changes here |
@strawgate I get errors on startup when running this version on my HA box. In the past, HA required that all third-party import statements (
|
I know what causes this and I'm very surprised I didn't run into it -- I'll get this fixed and try to figure out why it's not happening on my instance |
@legrego I have fixed the namespace issue as we discussed. Sorry about that. I have verified my HA instance is using the latest commit here and is working now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, tested locally and all seems to be working as intended. Thanks!
from custom_components.elasticsearch.es_gateway_8 import Elasticsearch8Gateway, Gateway8Settings | ||
|
||
# import custom_components.elasticsearch # noqa: F401 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit, remove?
# import custom_components.elasticsearch # noqa: F401 |
# @property | ||
# def entity(self) -> RegistryEntry: | ||
# """Return the Hass RegistryEntry object.""" | ||
# return self._entity |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
# @property | |
# def entity(self) -> RegistryEntry: | |
# """Return the Hass RegistryEntry object.""" | |
# return self._entity |
Non-test Changes
Test Changes