Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Din99 DeltaE #11

Merged
merged 12 commits into from
Oct 4, 2022
Merged

Din99 DeltaE #11

merged 12 commits into from
Oct 4, 2022

Conversation

o1lo01ol1o
Copy link
Contributor

This ports the LAB to DIN99 and delta E metric from https://github.com/colour-science/colour. There may be some issues on the docstrings (they fail due to floating point errors on some platforms) and there's an API question of how to handle the kH and kCH parameters. Partially addresses #1

Copy link
Owner

@lehins lehins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a really great start. Thank you for doing this. Requests to change are mostly cosmetic.

I'll ponder a little on the way to add ability to supply extra parameters to color space conversions. This will definitely need a slight change to the api

Color/src/Graphics/Color/Space/DIN99.hs Outdated Show resolved Hide resolved
Color/src/Graphics/Color/Space/DIN99.hs Outdated Show resolved Hide resolved
Color/src/Graphics/Color/Space/DIN99.hs Outdated Show resolved Hide resolved
Color/src/Graphics/Color/Space/DIN99.hs Outdated Show resolved Hide resolved
Color/src/Graphics/Color/Space/DIN99.hs Outdated Show resolved Hide resolved
Color/src/Graphics/Color/Space/DIN99.hs Outdated Show resolved Hide resolved
Color/src/Graphics/Color/Space/DIN99.hs Outdated Show resolved Hide resolved
Color/src/Graphics/Color/Space/DIN99.hs Outdated Show resolved Hide resolved
@o1lo01ol1o o1lo01ol1o requested a review from lehins September 29, 2022 17:48
Copy link
Owner

@lehins lehins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's a good start for DIN99. Thank you.

I'll try to figure out later how we can adjust the api to supply extra options during color space conversion.

Copy link
Owner

@lehins lehins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think a bad import is the last thing

@lehins lehins merged commit 60fe65f into lehins:master Oct 4, 2022
@lehins
Copy link
Owner

lehins commented Oct 4, 2022

@o1lo01ol1o Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants