-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Din99 DeltaE #11
Din99 DeltaE #11
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a really great start. Thank you for doing this. Requests to change are mostly cosmetic.
I'll ponder a little on the way to add ability to supply extra parameters to color space conversions. This will definitely need a slight change to the api
Co-authored-by: Alexey Kuleshevich <[email protected]>
Co-authored-by: Alexey Kuleshevich <[email protected]>
Co-authored-by: Alexey Kuleshevich <[email protected]>
Co-authored-by: Alexey Kuleshevich <[email protected]>
Co-authored-by: Alexey Kuleshevich <[email protected]>
Co-authored-by: Alexey Kuleshevich <[email protected]>
Co-authored-by: Alexey Kuleshevich <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's a good start for DIN99. Thank you.
I'll try to figure out later how we can adjust the api to supply extra options during color space conversion.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think a bad import is the last thing
Co-authored-by: Alexey Kuleshevich <[email protected]>
@o1lo01ol1o Thank you! |
This ports the LAB to DIN99 and delta E metric from https://github.com/colour-science/colour. There may be some issues on the docstrings (they fail due to floating point errors on some platforms) and there's an API question of how to handle the
kH
andkCH
parameters. Partially addresses #1