feat(slogger): Improve logging #234
Open
+304
−98
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
uristdwarf
force-pushed
the
logging-improv
branch
2 times, most recently
from
51f94bf to
a945798
Compare
uristdwarf
requested review from
aNeutrino,
lgsilva3087,
antuan96314 and
ictus4u
uristdwarf
force-pushed
the
logging-improv
branch
from
a945798 to
2932942
Compare
uristdwarf
force-pushed
the
logging-improv
branch
from
9d684f8 to
88f7ef1
Compare
lgsilva3087
previously approved these changes
Dec 3, 2024
uristdwarf
force-pushed
the
logging-improv
branch
from
88f7ef1 to
874251a
Compare
This for example allows using environment variables to set logging levels.
This is to allow other libraries that don't link to common to use it (e.g slogger)
Previously, it wasn't possible to setup specific log levels. You had had to start with -d (debug) mode to get debug messages. This commit introduces adding specifc log levels using either LOG_LEVEL in config file, or using SAUNAFS_LOG_LEVEL from the environment It also fixes -d always setting the level to debug, which is what you may not want if you want the process to run in the foreground.
* Change most current debugs to the lower trace level * Change magic file log to trace level * Fix tests to use this new level
* Print system error messages instead of ignoring them
uristdwarf
force-pushed
the
logging-improv
branch
from
874251a to
c3c8d49
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These commits aim to improve the logging capabilities, and allow more fine-grained control of it. It also removes the -d option spamming worthless debug messages (by lowering them to trace, and using the config file to determine the logging level).