Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add database seeder to backend (#64) #91

Merged
merged 4 commits into from
Oct 9, 2020
Merged

add database seeder to backend (#64) #91

merged 4 commits into from
Oct 9, 2020

Conversation

mhalsubhi
Copy link
Contributor

Added database seeder to backend

local database in local development environment now can be seeded with actual data fetched from api

to seed database after clone the repo and cd to backend folder, use command npm run seed to seed local database

#64

@lgtm-com
Copy link

lgtm-com bot commented Oct 8, 2020

This pull request introduces 2 alerts when merging 1ac153f into f59d552 - view on LGTM.com

new alerts:

  • 2 for Missing variable declaration

@lelouchB
Copy link
Owner

lelouchB commented Oct 8, 2020

Hey @mhalsubhi
This looks awesome 👌
I will get to it sometime tommorow.

I am going to create an issue to properly demonstrate this in backend/README.md

Are you interested in that.

@mhalsubhi
Copy link
Contributor Author

@lelouchB yes, I'll create step by step guide for it 👍🏼

@lelouchB
Copy link
Owner

lelouchB commented Oct 8, 2020

@lelouchB yes, I'll create step by step guide for it 👍🏼

Comment on #92 so I can assign it you.

@lelouchB
Copy link
Owner

lelouchB commented Oct 8, 2020

This pull request introduces 2 alerts when merging 1ac153f into f59d552 - view on LGTM.com

new alerts:

  • 2 for Missing variable declaration

Can you look into this

@mhalsubhi
Copy link
Contributor Author

mhalsubhi commented Oct 8, 2020

@lelouchB maybe if changed it to for (var character of characters) it will be solved, I'll try now 👍🏼

@mhalsubhi
Copy link
Contributor Author

@lelouchB resolved 👍🏼

backend/seeder.js Outdated Show resolved Hide resolved
@lelouchB
Copy link
Owner

lelouchB commented Oct 9, 2020

@mhalsubhi
I tested this on my local machine, it works great.
Nice 👍
Can you move seeder.js to another directory. It should not be in root.
Maybe helpers or a new directory seeder?

Thanks

@mhalsubhi
Copy link
Contributor Author

@lelouchB sure, I will move the file to helpers folder

@lelouchB
Copy link
Owner

lelouchB commented Oct 9, 2020

Hey @mhalsubhi
Can you resolve these conflicts so I can merge this?

Thanks

@lelouchB
Copy link
Owner

lelouchB commented Oct 9, 2020

@mhalsubhi
I am going to remove the images from README.md. They just don't fulfill the purpose I wanted. The problem is not with the images, I am sorry for doing this after making you add them.

I apologize for this.

@mhalsubhi
Copy link
Contributor Author

Hey @mhalsubhi
Can you resolve these conflicts so I can merge this?

Thanks

@lelouchB I will try 👍🏼

@mhalsubhi
I am going to remove the images from README.md. They just don't fulfill the purpose I wanted. The problem is not with the images, I am sorry for doing this after making you add them.

I apologize for this.

No worries it's totally ok for me 😃

@lelouchB lelouchB merged commit fe2e052 into lelouchB:main Oct 9, 2020
@lelouchB
Copy link
Owner

lelouchB commented Oct 9, 2020

hey @mhalsubhi
there are some linting issues do you think you can send a fix for these?
Don't why but npm run lint:fix command is not working properly

@mhalsubhi
Copy link
Contributor Author

@lelouchB sure, I will give it a try 👍🏼

@lelouchB
Copy link
Owner

lelouchB commented Oct 9, 2020

hey @mhalsubhi
there are some linting issues do you think you can send a fix for these?
Don't why but npm run lint:fix command is not working properly

Maybe the errors are not auto fixable.

@mhalsubhi mhalsubhi mentioned this pull request Oct 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants