Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update all outdated dependencies #468

Merged
merged 9 commits into from
Aug 15, 2023
Merged

Conversation

reecejohnson
Copy link
Contributor

@reecejohnson reecejohnson commented Aug 3, 2023

@height
Copy link

height bot commented Aug 3, 2023

Link Height tasks by mentioning a task ID in the pull request title or commit messages, or description and comments with the keyword link (e.g. "Link T-123").

💡Tip: You can also use "Close T-X" to automatically close a task when the pull request is merged.

@changeset-bot
Copy link

changeset-bot bot commented Aug 3, 2023

⚠️ No Changeset found

Latest commit: 5a57e35

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link

vercel bot commented Aug 3, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
lens-sdk-example-web-wagmi ✅ Ready (Inspect) Visit Preview Aug 14, 2023 2:32pm

…and related files and remove relating eslint ignores
package.json Outdated
@@ -26,7 +26,7 @@
"prettier": "^2.8.4",
"rimraf": "^4.1.2",
"turbo": "^1.8.1",
"typedoc": "^0.23.27",
"typedoc": "^0.24.0",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

did you check if pnpm typedoc still works? I remember having some issues with the updated version some time ago.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yep, you're right.

big breaking changes introduced in 0.24.0 regarding the package entryPointStrategy.

reverting the version and creating separate ticket

@@ -71,7 +71,7 @@
"@lens-protocol/eslint-config": "workspace:*",
"@lens-protocol/prettier-config": "workspace:*",
"@lens-protocol/tsconfig": "workspace:*",
"@types/jest": "29.2.3",
"@types/jest": "29.5.3",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Given the build passes I assume we don't have type checks issue with our use of Jest.

There is warning at the end of this Jest doc page: https://jestjs.io/docs/getting-started#type-definitions that suggests to keep types and jest versions as in sync as possible. I think they also follow semver so higher version of the types should support older version of Jest.

image

Let's keep an eye on it.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Noted, thanks 👍

@reecejohnson reecejohnson merged commit 74cdc86 into main Aug 15, 2023
1 check passed
@reecejohnson reecejohnson deleted the chore/dep-updates branch August 15, 2023 08:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants