-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: update all outdated dependencies #468
Conversation
|
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
…and related files and remove relating eslint ignores
package.json
Outdated
@@ -26,7 +26,7 @@ | |||
"prettier": "^2.8.4", | |||
"rimraf": "^4.1.2", | |||
"turbo": "^1.8.1", | |||
"typedoc": "^0.23.27", | |||
"typedoc": "^0.24.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
did you check if pnpm typedoc
still works? I remember having some issues with the updated version some time ago.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yep, you're right.
big breaking changes introduced in 0.24.0
regarding the package
entryPointStrategy.
reverting the version and creating separate ticket
@@ -71,7 +71,7 @@ | |||
"@lens-protocol/eslint-config": "workspace:*", | |||
"@lens-protocol/prettier-config": "workspace:*", | |||
"@lens-protocol/tsconfig": "workspace:*", | |||
"@types/jest": "29.2.3", | |||
"@types/jest": "29.5.3", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Given the build passes I assume we don't have type checks issue with our use of Jest.
There is warning at the end of this Jest doc page: https://jestjs.io/docs/getting-started#type-definitions that suggests to keep types and jest versions as in sync as possible. I think they also follow semver so higher version of the types should support older version of Jest.
Let's keep an eye on it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Noted, thanks 👍
Updates deps as suggesting by renovate:
Disables
@typescript-eslint/no-unsafe-assignment
in test files and removes related eslint ignores. Allows the useexpect.any(String)
(and similar).