Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: react native origin header #927

Merged
merged 1 commit into from
May 13, 2024
Merged

fix: react native origin header #927

merged 1 commit into from
May 13, 2024

Conversation

krzysu
Copy link
Contributor

@krzysu krzysu commented Apr 29, 2024

No description provided.

@height Height
Copy link

height bot commented Apr 29, 2024

Link Height tasks by mentioning a task ID in the pull request title or commit messages, or description and comments with the keyword link (e.g. "Link T-123").

💡Tip: You can also use "Close T-X" to automatically close a task when the pull request is merged.

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Apr 29, 2024

🦋 Changeset detected

Latest commit: bef1ed9

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 5 packages
Name Type
@lens-protocol/api-bindings Patch
@lens-protocol/react Patch
@lens-protocol/react-native Patch
@lens-protocol/react-web Patch
@lens-protocol/wagmi Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel Vercel
Copy link

vercel bot commented Apr 29, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
lens-sdk-example-web-wagmi ✅ Ready (Inspect) Visit Preview Apr 29, 2024 3:25pm

@krzysu krzysu requested a review from cesarenaldi April 29, 2024 15:23
cesarenaldi
cesarenaldi reviewed Apr 30, 2024
View reviewed changes
packages/api-bindings/src/apollo/index.ts
};

export function createAuthApolloClient({ uri, logger }: AuthApolloClientConfig) {
export function createAuthApolloClient({ logger, origin, uri }: AuthApolloClientConfig) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why only for this ApolloClient and not the authenticated one?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought the origin overwrite is used only in the auth challenge and is not used later. or is it?
is the API doing anything else based on origin?

@krzysu krzysu merged commit 21f652d into develop May 13, 2024
6 checks passed
@krzysu krzysu deleted the fix-react-native-origin branch May 13, 2024 07:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cesarenaldi cesarenaldi cesarenaldi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@krzysu @cesarenaldi