Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: axios 1.x #537

Merged
merged 1 commit into from
Feb 9, 2024
Merged

feat: axios 1.x #537

merged 1 commit into from
Feb 9, 2024

Conversation

panuhorsmalahti
Copy link
Collaborator

  • Update axios to 1.x so that getAdapter is possible. require("axios/lib/adapters/http"); was always incorrect (but happened to work)
  • Adds support for properly setting httpAdapter for Node.js usage (from e.g. electron's renderer)
  • Makes the sdk more compatible with esbuild

@panuhorsmalahti panuhorsmalahti requested review from chenhunghan and a team February 9, 2024 12:57
@chenhunghan
Copy link
Collaborator

Can't we just use global.fetch?

@panuhorsmalahti
Copy link
Collaborator Author

@chenhunghan that would not work when called from Electron renderer as it could cause a CORS error.

@panuhorsmalahti panuhorsmalahti merged commit 494ec12 into main Feb 9, 2024
7 checks passed
@panuhorsmalahti panuhorsmalahti deleted the feature/axios-1 branch February 9, 2024 13:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aleksfront aleksfront aleksfront approved these changes

@chenhunghan chenhunghan Awaiting requested review from chenhunghan

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@panuhorsmalahti @chenhunghan @aleksfront