Add JsonFormatStreamReader #878
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@andmarios Could someone your team review this? I need this change as well to backup everything from kafka (timestamp, key, value, headers, and message) |
davidsloan
requested changes
Jan 11, 2023
There was a problem hiding this comment.
Sorry for taking a while to look at this one.
A few comments:
- Please remove "CONTRIBUTING" file - we will be adding something similar soon. Also not appropriate for us to have any mention of other companies.
- Addition of Dockerfile looks good but please can you document how this is used or how this can help development in the README.
- I don't think the MANIFEST.MF is necessary as this should be generated by the assembly process? Is there a reason you needed to add this?
- Any code addition should be covered with unit tests so as to ensure the code is bug-free and cover against future regressions. We plan on covering this in some contribution guidelines in future, apologies for not making this clear.
|
I forgot to mention, thank you for the contribution @iosifnicolae2 👍 |
|
@davidsloan thank you for your review, unfortunetly we're not using anymore this functionality so I cannot allocate more time on fixing all the requested changes. @fqlx if you have time feel free to fix the requested changes and open a new PR Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.