Various fixes (#24)

* Various fixes, mostly warnings * Update description
leolost2605 · Dec 23, 2023 · 40dc5c6 · 40dc5c6
1 parent db356b1
commit 40dc5c6
Show file tree

Hide file tree

Showing 4 changed files with 15 additions and 14 deletions.
diff --git a/data/io.github.leolost2605.gradebook.metainfo.xml b/data/io.github.leolost2605.gradebook.metainfo.xml
@@ -10,8 +10,15 @@
 
   <description>
     <p>
-      A simple tool to keep track of your grades! It supports numerical grading systems as well as percentage grades.
+      Gradebook is a simple tool that helps you keep track of your grades. This way you always know how you are doing in your courses.
     </p>
+    <p>Features:</p>
+      <ul>
+        <li>Support for numerical and percentage systems</li>
+        <li>Assign your grades to categories with different weighting</li>
+        <li>Add notes to your grades so that you later know how you could improve</li>
+        <li>Your average is calculated automatically taking the weighting of the different categories into account</li>
+      </ul>
   </description>
 
   <developer_name>Leonhard Kargl</developer_name>

diff --git a/src/application.vala b/src/application.vala
@@ -10,21 +10,16 @@ public class MyApp : Adw.Application {
 
     construct {
         ActionEntry[] action_entries = {
-            { "test", this.on_test_action },
             { "help", this.on_help_action },
             { "about", this.on_about_action },
             { "newsubject", this.on_newsubject_action},
         };
         this.add_action_entries (action_entries, this);
     }
 
-    public void on_test_action () {
-        print ("test_action");
-    }
-
-
     public void on_help_action () {
-        Gtk.show_uri (main_window, "https://github.com/leolost2605/Gradebook/wiki", 0);
+        var uri_launcher = new Gtk.UriLauncher ("https://github.com/leolost2605/Gradebook/wiki");
+        uri_launcher.launch.begin (main_window, null);
     }
 
     public void on_newsubject_action () {
@@ -34,7 +29,7 @@ public class MyApp : Adw.Application {
                 SubjectManager.get_default ().new_subject (dialog.name_entry_box.get_text (), dialog.get_categories ());
             }
             dialog.destroy ();
- 	    return true;
+ 	        return true;
         });
         dialog.present ();
     }
@@ -47,7 +42,7 @@ public class MyApp : Adw.Application {
             translator_credits = _("translator-credits"),
             application_name = _("Gradebook"),
             application_icon = "io.github.leolost2605.gradebook",
-            version = "1.1.1",
+            version = "1.2",
             license_type = GPL_3_0,
             website = "https://github.com/leolost2605/Gradebook",
             issue_url = "https://github.com/leolost2605/Gradebook/issues",

diff --git a/src/subject-manager.vala b/src/subject-manager.vala
@@ -44,7 +44,7 @@ public class SubjectManager : Object {
 
     public async void read_data () {
         yield read_data_legacy ();
-        
+
         var keyfile = new KeyFile ();
 
         try {
@@ -70,7 +70,6 @@ public class SubjectManager : Object {
     public async void write_data () {
         var keyfile = new KeyFile ();
 
-        var parser = new SubjectParser ();
         for (int i = 0; i < subjects.get_n_items (); i++) {
             var subject = (Subject) subjects.get_item (i);
 

diff --git a/src/window.vala b/src/window.vala
@@ -71,10 +71,10 @@ public class Window : Adw.ApplicationWindow {
             navigation_sidebar.select_row (navigation_sidebar.get_row_at_index ((int) pos));
         });
 
-        subject_manager.read_data ();
+        subject_manager.read_data.begin ();
 
         close_request.connect (() => {
-            set_visible (false);
+            visible = false;
             subject_manager.write_data.begin (() => {
                 destroy ();
             });