Update Gradebook user interface

[turtlegarden]

Preview

Skarminspelning.fran.2023-10-30.00-09-51.webm

Explanation

This pull request completely remakes the UI of Gradebook, updating it to the latest GNOME 45 HIG.

Downfalls

• For some reason, adding a category after a subject is created does not work. I am unsure why this happens. Everything else should work very well!
• I removed the Date function on Grades because it would take too much effort to create a date widget for something that does not need dating (and if this is really needed, one can put it in the note).

I hope you enjoy!

Note: for development purposes, there is a flatpak build JSON compatible with GNOME Builder included. Please tell me if it works when built on the yaml and if I should remove the .json file!

[turtlegarden]

Hello, any updates on this?

[turtlegarden]

Hello, it has been three weeks yet there is no response to this patch. Could you please respond with a status update?

[turtlegarden]

This pull request is stale, I am closing it. Feel free to review it if this app is still maintained. I would have appreciated some sort of reply.

[leolost2605]

First of all thanks a lot for this massive PR! Second I am very sorry I didn't reply sooner I'm currently quite occupied with university and admittedly kind of forgot about this :(

If you are still interested in working on this here are some things I saw while quickly looking over it:

• The .flatpak-builder folder shouldn't be included in git
• While running I get some criticals which isn't very good:

(io.github.leolost2605.gradebook:2): Gtk-CRITICAL **: 18:52:56.380: gtk_widget_get_name: assertion 'GTK_IS_WIDGET (widget)' failed

(io.github.leolost2605.gradebook:2): Gtk-CRITICAL **: 18:52:56.380: gtk_widget_get_name: assertion 'GTK_IS_WIDGET (widget)' failed

(io.github.leolost2605.gradebook:2): Adwaita-CRITICAL **: 18:53:11.849: adw_window_set_content: assertion 'gtk_widget_get_parent (content) == NULL' failed

(io.github.leolost2605.gradebook:2): Gtk-CRITICAL **: 18:53:11.849: gtk_box_remove: assertion 'GTK_IS_WIDGET (child)' failed

(io.github.leolost2605.gradebook:2): Gtk-CRITICAL **: 18:53:11.849: gtk_box_remove: assertion 'GTK_IS_WIDGET (child)' failed

(io.github.leolost2605.gradebook:2): Gtk-CRITICAL **: 18:53:11.851: gtk_box_append: assertion 'GTK_IS_WIDGET (child)' failed

(io.github.leolost2605.gradebook:2): Adwaita-CRITICAL **: 18:53:17.866: adw_window_set_content: assertion 'gtk_widget_get_parent (content) == NULL' failed

I'll try to do a detailed review ASAP!
Apart from that it looks very good and the new UI looks amazing! Great work! 🎉

[leolost2605]

Ok nevermind the detailed review I just remembered how unorganized I did things back then and what an ugly codebase this is so I think it's better to just merge this and go to cleaning up the whole thing later 😅

So if it's ok with you I'll remove the .flatpak-builder folder from git and the merge this :)

[turtlegarden]

Oh no, the .flatpak-builder folder made it in? That is not good, I will delete it right now, as well as apply your changes :)

[turtlegarden]

Would it be okay if I run a formatter on this? My formatting is all over the place 😅️

[leolost2605]

Sure go ahead! Although I think we might want to run a formatter on the whole codebase as it's formatting is all over the place anyways 😅