Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: ✨ add AsciiDoc support (Asciidoctor icon) #334

Merged
merged 3 commits into from
Aug 21, 2024
Merged

feat: ✨ add AsciiDoc support (Asciidoctor icon) #334

merged 3 commits into from
Aug 21, 2024

Conversation

Naveandice
Copy link
Contributor

👋 Hello again, I added AsciiDoc support. The AsciiDoc logo is copyrighted by Eclipse (and I don't wanna read their long legal papers about branding), so I replaced it with the Asciidoctor logo. It doesn't look as good as I wanted, though.

@ItsPi3141
Copy link
Contributor

Please take a look at the icon color guidelines here. I would revert commit bb028d5.

@Naveandice
Copy link
Contributor Author

It's hard to follow any guidelines about colors when it's all about different monitors displaying different colors.

I've got back the ea23b0c icon and changed it's background HSL to 342deg 25% 18%. Looking for suggestions.

Preview

asciidoc

@ItsPi3141
Copy link
Contributor

I think that's good 👍

@xhayper xhayper added the enhancement New feature or request label Aug 21, 2024
@xhayper xhayper merged commit 6ed6853 into leonardssh:main Aug 21, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants