[GCI '18] Added Code Coverage to 'cloud-storage' Unit Tests #36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Added Code Coverage - Used Ava.js & Istanbul, a JavaScript test coverage tool. - Imported nyc from Istanbul in particular for coverage purposes - Ignored MacOS junk by adding it in .gitignore
dilantha111
approved these changes
Dec 6, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added Code Coverage
Used Ava.js & Istanbul, a JavaScript test coverage tool.
Imported nyc from Istanbul in particular for coverage purposes
Ignored MacOS junk by adding it in .gitignore
This is how the coverage test looks like!
Improved Dynamic Command Registering
Included
const fs = require('fs');Saved base (main) path
Searching all folders inside 'cli-commands' to grab all implementations of cmd.js
Mapping them using the commandsArray
Deleted src/services/index.js
Before
After
Removed
Successful