Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixed issue13 #46

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fixed issue13 #46

wants to merge 1 commit into from

Conversation

MarkChenYutian
Copy link

  • added --pretty flag for cli
  • refactored logger function in helper.js to take one more parameter for
    prettification
  • refactored logger calls in services.js
  • added cli-table3 as dependency

@MarkChenYutian MarkChenYutian mentioned this pull request Dec 29, 2019
Open
@MarkChenYutian
Copy link
Author

#13

TRomesh
TRomesh requested changes Dec 31, 2019
View reviewed changes
Copy link
Collaborator

@TRomesh TRomesh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Noticed that you have changed nc to nodec any particular reason for that change?. We used "nc" so when we publish this library as cli we can call it by "nc". Apart from that you code looks good.

package.json Outdated Show resolved Hide resolved
@Mr-Wiredancer
fix issue#13
66bea18 
* added --pretty flag for cli
* refactored logger function in helper.js to take one more parameter for prettification
* refactored logger calls in services.js
* added cli-table3 as dependency
@MarkChenYutian
Copy link
Author

@TRomesh I reset and changed the unintended line back.

TRomesh
TRomesh approved these changes Dec 31, 2019
View reviewed changes
Copy link
Collaborator

@TRomesh TRomesh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TRomesh TRomesh TRomesh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@MarkChenYutian @TRomesh @Mr-Wiredancer