Added emojis #58
Open
Added emojis #58
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TRomesh
requested changes
Jan 9, 2020
lib/compute.js
Outdated
| @@ -7,7 +8,8 @@ class Compute { | |||
| } else if (program.type == "Azure") { | |||
| this._compute = ncProviders.azure.compute(options); | |||
| } else { | |||
| throw new Error("Please specify a provider by flag -p --provider"); | |||
| const emoji = require("node-emoji"); | |||
There was a problem hiding this comment.
Do not put import statements here like this they should be done on the top.
There was a problem hiding this comment.
Since its a common thing you can move it to helper.js and import it as a function
lib/database.js
Outdated
| @@ -7,7 +7,8 @@ class Database { | |||
| } else if (program.type == "Azure" || "azure") { | |||
| this._database = nodecloud.azure.compute(options); | |||
| } else { | |||
| throw new Error("Please specify a provider by flag -p --provider"); | |||
| const emoji = require("node-emoji"); | |||
There was a problem hiding this comment.
Do not put import statements here like this they should be done on the top.
There was a problem hiding this comment.
Since its a common thing you can move it to helper.js and import it as a function
lib/network.js
Outdated
| @@ -1,26 +1,27 @@ | |||
| class Network { | |||
| constructor(program, nodecloud, options) { | |||
| const emoji = require("node-emoji"); | |||
There was a problem hiding this comment.
Do not put import statements here like this they should be done on the top.
JaDogg
suggested changes
Jan 10, 2020
README.md
Outdated
| @@ -1,7 +1,8 @@ | |||
| # nodecloud-cli | |||
|
|
|||
| nodecloud-cli is an unified command line interface for open cloud based on [nodecloud](https://github.com/cloudlibz/nodecloud). nodecloud-cli supports cloud providers like AWS, Azure, GCP and many more. | |||
|
|
|||
| Very Simple to Use. | |||
There was a problem hiding this comment.
Can you revert the change to README.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have added emojis to the cli