-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(docs): Updated README.md #128
base: main
Are you sure you want to change the base?
Conversation
docs(global): Added "The Problem" and "The Solution" to README.MD README.MD now has headers The Problem and The Solution with relevant information from the YouTube video "React Email Final Demo | Google Summer of Code 2022 | GSoC'22 | SCoRe Lab - Leopards Lab"
✅ Deploy Preview for docs-react-email-leopardslab ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
Ahhh! forgot to fix the yarn prettier issue. going to fix that now... |
errors with line breaks and such caused yarn prettier to throw an error.
I've looked over prettier and all issues regarding prettier should be fixed... if prettier is still giving out errors, then I have no idea what is causing it to do so. |
@Logan-kwan how you fix that yarn prettier issue, it's showing me error |
i tried to separate the paragraph i wrote using line breaks; i'm not sure if that solved the issue, though. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Kindly pull the recent changes and solve the merge conflicts @Logan-kwan
Also, don't submit the pull request directly from your main
branch, always create a separate branch and do the changes.
Coming to the prettier issue, just run yarn pretty:fix
or npm run pretty:fix
to automatically fix the issues before pushing the code.
Also, for the commit message, the type
will be docs
, and scope
will be readme
followed by the title and description of the proper changes.
Added "The Problem" and "The Solution" to README.MD
README.MD now has headers The Problem and The Solution with relevant information from the YouTube video "React Email Final Demo | Google Summer of Code 2022 | GSoC'22 | SCoRe Lab - Leopards Lab"