Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(docs): Updated README.md #128

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Conversation

Logan-kwan
Copy link

Added "The Problem" and "The Solution" to README.MD

README.MD now has headers The Problem and The Solution with relevant information from the YouTube video "React Email Final Demo | Google Summer of Code 2022 | GSoC'22 | SCoRe Lab - Leopards Lab"

docs(global): Added "The Problem" and "The Solution" to README.MD

README.MD now has headers The Problem and The Solution with relevant information from the YouTube video "React Email Final Demo | Google Summer of Code 2022 | GSoC'22 | SCoRe Lab - Leopards Lab"
@netlify
Copy link

netlify bot commented Oct 18, 2022

Deploy Preview for docs-react-email-leopardslab ready!

Name Link
🔨 Latest commit 3747cd2
🔍 Latest deploy log https://app.netlify.com/sites/docs-react-email-leopardslab/deploys/634ec8c92500450009662ea8
😎 Deploy Preview https://deploy-preview-128--docs-react-email-leopardslab.netlify.app/typedoc
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@Logan-kwan
Copy link
Author

Ahhh! forgot to fix the yarn prettier issue. going to fix that now...

errors with line breaks and such caused yarn prettier to throw an error.
@Logan-kwan
Copy link
Author

I've looked over prettier and all issues regarding prettier should be fixed...

if prettier is still giving out errors, then I have no idea what is causing it to do so.

@SabujGolui
Copy link

SabujGolui commented Oct 22, 2022

@Logan-kwan how you fix that yarn prettier issue, it's showing me error

@Logan-kwan
Copy link
Author

i tried to separate the paragraph i wrote using line breaks; i'm not sure if that solved the issue, though.

Copy link
Member

@niloysikdar niloysikdar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Kindly pull the recent changes and solve the merge conflicts @Logan-kwan
Also, don't submit the pull request directly from your main branch, always create a separate branch and do the changes.

Coming to the prettier issue, just run yarn pretty:fix or npm run pretty:fix to automatically fix the issues before pushing the code.

Also, for the commit message, the type will be docs, and scope will be readme followed by the title and description of the proper changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants