Merge branch 'fixReviewFormImport-831' into 'main'

Fixes review form import See merge request softwares-pkp/plugins_ojs/fullJournalTransfer!58
lepidus · Jun 7, 2024 · bf0cdc9 · bf0cdc9
2 parents 2b43923 + 8208946
commit bf0cdc9
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 4 deletions.
diff --git a/filter/import/NativeXmlExtendedArticleFilter.inc.php b/filter/import/NativeXmlExtendedArticleFilter.inc.php
@@ -277,7 +277,7 @@ public function parseReviewAssignment($node, $reviewRound)
         $reviewAssignment->setUnconsidered((int) $node->getAttribute('unconsidered'));
 
         if ($reviewFormId = $node->getAttribute('review_form_id')) {
-            $reviewAssignment->setReviewFormId($reviewFormId);
+            $reviewAssignment->setReviewFormId($deployment->getReviewFormDBId($reviewFormId));
         }
         if ($quality = $node->getAttribute('quality')) {
             $reviewAssignment->setQuality($quality);

diff --git a/tests/import/NativeXmlExtendedArticleFilterTest.php b/tests/import/NativeXmlExtendedArticleFilterTest.php
@@ -121,7 +121,6 @@ public function testParseReviewAssignment()
         $expectedReviewAssignment = new ReviewAssignment();
         $expectedReviewAssignment->setReviewerId($reviewer->getId());
         $expectedReviewAssignment->setSubmissionId($reviewRound->getSubmissionId());
-        $expectedReviewAssignment->setReviewFormId(35);
         $expectedReviewAssignment->setReviewRoundId($reviewRound->getId());
         $expectedReviewAssignment->setReviewerFullName($reviewer->getFullName());
         $expectedReviewAssignment->setRound($reviewRound->getRound());

diff --git a/version.xml b/version.xml
@@ -10,7 +10,7 @@
 <version>
 	<application>fullJournalTransfer</application>
 	<type>plugins.importexport</type>
-	<release>2.0.12.0</release>
-	<date>2024-05-17</date>
+	<release>2.0.13.0</release>
+	<date>2024-06-07</date>
     <class>FullJournalImportExportPlugin</class>
 </version>