-
-
Notifications
You must be signed in to change notification settings - Fork 785
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Let TitleBar show 'SystemMenu' on mouse right button up. #627
Conversation
--- Commit by LHTXQ
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have the users @LHTXQ on file. In order for us to review and merge your code, please contact the project maintainers to get yourself added. |
This is my first pull request, it seems something wrong in the progress, please tell me how to make it right. |
Maybe we should give the SystemMenua a more modern appearance in keeping with the Wpfui style,but I don't know how to modify it. In addition, we can also add a function to let user insert or delete menu items in SystemMenu(just like Edge browser's SystemMenu). |
Perhaps it would be easier to replace it with a custom menu altogether. Then we could give people a high-level WPF API where they can simply add additional items, and perhaps boolean properties to remove some default items. |
I think even Windows isn't sure about how it's supposed to look like yet. I just checked Notepad (which uses the Fluent look for some time), and the menu looks identical to your screenshot. Then I checked the Settings app, and it's almost the same, but it respects the dark theme.
IMO that would be nice, however I would definitely think of it as a separate feature to follow this one. With this, we're just providing a way to invoke native functionality that was not available (compared to WPF). Something that should just work "out of the box" and doesn't require any "design decisions" as to how to expose it to the users of the library. |
--- Commit by LHTXQ
Show 'SystemMenu' on mouse right button up.
Pull request type
What is the current behavior?
Do nothing on mouse right button up.
Issue Number: N/A
What is the new behavior?
Show 'SystemMenu' on mouse right button up.