-
Notifications
You must be signed in to change notification settings - Fork 6
Some new features and improvements #4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Thank you for publishing these changes and making a PR! I've not started reviewing this PR yet. Based on the size, I may pull some of these changes into the repo with smaller commits. I'll discuss here before doing that. I'll definitely set the Thanks again! |
@leptos-null I have completed the implementation of |
Thank you! I'm thinking about breaking the changes up into these commits:
Changes in this PR that I'm considering to not merge:
Other changes:
(to be clear, I'm still thinking about some of these, just sharing them; I'll make all these changes, if I decide to, when I commit to this repo) |
This PR change is very large and is mainly used for RuntimeViewer application, which you can absolutely choose not to merge or partially merge.
This library is the core of RuntimeViewer and I will continue to add new features to it, here is what I think could be improved.
Finally, thank you very much for creating this library!