cargo leptos build fails, fixed issue for macos, which always builds into target/aarch64-apple-darwin #422
Conversation
…nt for testing
…rsion from upstream
Merged upstream main into dev # Conflicts: # Cargo.lock # Cargo.toml
# Conflicts: # Cargo.lock
added filters feature to insta test, patched the tests to accept the target output of the changed bin_packageAdd platform-based target handling and test filters. Ensure the build target defaults to the current platform when unspecified, and add the "filters" feature to Insta for consistent test snapshots. Update tests to accommodate platform-specific output and adjust bin package logic for accurate file detection.
…added accordingly, be it in bin_package.rs or project.rs, so the args are correctly pushed into server.rs
|
@holg Can you fix the conflicts, and I'll review the changes? |
# Conflicts: # Cargo.lock # Cargo.toml
|
|
The downside to this PR is that it changes the location of the output files for at least some of our users. Instead of being in I'm also less sure if I noticed this behavior on my M1 mac, so I wonder if there's something more involved here |
Hi Ben, |
cargo leptos build fails, fixed issue for macos, which always builds into target/aarch64-apple-darwin
The issue here, as well as for cross-platform builds, is:
on macos the binary is alwasy put into target/aarch64[|x86_64]/
thus the binary later is not found.
I already made a fix, but it failed some tests, sorry!
Now i made the fix differently, to always add the target directly in the config.
The tests needed to be adapted to be more dynamic, as the target_triple is variable.
Have as well a look onto
fix issue #358 #359
in which @gbj rightfully complained about the kind of the fix.
So it shall be OK now.