Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accept comment threshold configuration at the top level. #7

Merged
merged 3 commits into from
Oct 10, 2023

Conversation

lerebear
Copy link
Owner

Closes #6.

This also:

  • Bumps sizeup-core to 0.2.0, where support for threshold configuration in that library has been dropped.
  • Makes a breaking change to the configuration format in order to group configs for labeling and commenting under top-level keys.

Also, for clarity group configs for labelling and commenting under
top-level keys.
That version drops support for the `category.threshold` configuration
option, which we've already replaced functionally in this tool. This
drops that last references to that config in docs too.
@lerebear lerebear merged commit 8659e51 into main Oct 10, 2023
2 checks passed
@lerebear lerebear deleted the lerebear-threshold-config branch October 10, 2023 06:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Accept comment threshold configuration flag at the top-level
1 participant