Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR consists mostly of typos.
I can also make the rendered notebooks (what is your procedure for doing this?)
Some suggestions:
01_adult_census_exploration:
adult_census.profile_report()
told us that there are a few duplicate rows. It may be worthwhile explaining how these duplicate entries may affect/not affect prediction?02_basic_preprocessing
StandardScaler
does? Maybe not everyone knows the equation?03_basic_parameters_tuning
C
. Maybe even just give them a useful link to read on regularisation and overfitting?you don't provide a
Cs
argument like you do above and it might be worth mentioning that by default it tests a grid of 10C
values.