WIP #846 Initial idea for unit tests for ModLibrary #919
Conversation
add a fileshystem stub for the filesystem functions used in
ModLibrary::rescan
ideas: make a struct with function pointers, why?
* simpler than virtual (yes, it is)
* allows us to easily use std::filesystem::functions, no need for
wrappers
* we don't use gmock anyways, so mocking isn't as easy
* simpler than virtual (yes, I really don't like 'em, that's why it's
twice)
very much WIP, didn't test much, it's really late, this commit message
will change :)
| #include <catch.hpp> | ||
| RIGEL_RESTORE_WARNINGS | ||
|
|
||
| #include <cstdio> |
There was a problem hiding this comment.
why did I leave this here?
|
|
||
| Filesystem mockFsHandle{ | ||
| [](const std::filesystem::path& p, std::error_code& ec) noexcept -> bool | ||
| { return true; }, |
There was a problem hiding this comment.
foolish mocks, but I just wanted a proof of concept
There was a problem hiding this comment.
even without Gmock we can mock these nicely, we can use some static arrays of booleans and iterate through them with a counter (similar to WillOnce/WillRepeteadely)
I think we can also hack the directory iteration function for all the calls we need (similarly with an array and counter) since we expect that one to be called twice - doable
| test_spike_ball.cpp | ||
| test_string_utils.cpp | ||
| test_timing.cpp | ||
| # test_array_view.cpp |
There was a problem hiding this comment.
note to self: so that I can compile faster, remove these when ready
| @@ -21,6 +21,27 @@ | |||
| #include <tuple> | |||
| #include <vector> | |||
|
|
|||
| struct Filesystem | |||
There was a problem hiding this comment.
note to self, move/rename when done, discuss with Nikolai
| DirectoryIterateFuncT f_directory_iterate; | ||
| }; | ||
|
|
||
| extern const Filesystem gNativeFilesystemHandle; |
There was a problem hiding this comment.
maybe we could extend this for other purposes
| { | ||
| return false; | ||
| } | ||
|
|
||
| if (!entry.exists(err) || err) | ||
| if (!fsHandle.f_exists(entry, err) || err) |
There was a problem hiding this comment.
note to self: adapt to this code base's style guide (sorry! was in a rush for a Proof of Concept)
|
Hi @bencsikandrei, good to see you back and thanks for the PR! I closed the issue but it's still relevant, you're very welcome to work on it if you're interested. Basically, I recently did a bit of cleanup and closed a whole bunch of issues that I don't realistically see myself getting around to anytime soon - I don't really have much time for the project at the moment. But reviewing and discussing should be doable. I'll have a closer look at the proposal when I have time, and let you know what I think! |
hi, @lethal-guitar hope you're doing well!
I've noticed you closed this issue: #846. Why? I just came up with, I think, a cool idea to solve it!
I'm not there yet, but inching closer. Need to get some sleep soon (real late here) but if you approve of this idea, I'll absolutely go the extra mile!
Main points:
Add a fileshystem "stub" (handle?) for the filesystem functions used in
ModLibrary::rescanideas: make a struct with function pointers, why?
very veeeery much WIP, didn't test much apart from building the code and the unit test, didn't even have time to step through the debugger, it's really late, this commit message will change :)
@lethal-guitar what do you think? worth pursuing?
here's some logs from the current unit test (it's very basic of course):