Skip to content
This repository has been archived by the owner on Jan 26, 2023. It is now read-only.

example hcl minor cleanup #33

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

example hcl minor cleanup #33

wants to merge 2 commits into from

Conversation

jcjones
Copy link

@jcjones jcjones commented Jul 29, 2022

The attache-control task does not need to advertise the redis-server's port, nor does it need to use a tcp liveness check on the redis-server. That's the redis-server's task's job.

…s port, nor does it need to use a tcp liveness check on the redis-server. That's the redis-server's task's job.
@codecov-commenter
Copy link

codecov-commenter commented Jul 29, 2022

Codecov Report

❗ No coverage uploaded for pull request base (main@0db713b). Click here to learn what that means.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main      #33   +/-   ##
=======================================
  Coverage        ?   35.05%           
=======================================
  Files           ?        2           
  Lines           ?      194           
  Branches        ?        0           
=======================================
  Hits            ?       68           
  Misses          ?      119           
  Partials        ?        7           
Flag Coverage Δ
attache 35.05% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0db713b...7fac550. Read the comment docs.

@pgporada pgporada self-requested a review August 10, 2022 15:53
Copy link
Member

@pgporada pgporada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should not be merged.

@jcjones
Copy link
Author

jcjones commented Aug 10, 2022

@pgporada fixed it, it now should be merged!

@jcjones jcjones requested a review from pgporada August 10, 2022 18:29
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants