Skip to content

Commit

Permalink
VA: Fix two IsCAAValid bugs (#7829)
Browse files Browse the repository at this point in the history
Fix two bugs introduced in #7816:
- Fix localLatency time for CAA rechecking is always 0
- Fix logEvent.InternalError is no longer being written to log
  • Loading branch information
beautifulentropy authored Nov 19, 2024
1 parent 577a1e3 commit 65de9fb
Showing 1 changed file with 5 additions and 0 deletions.
5 changes: 5 additions & 0 deletions va/caa.go
Original file line number Diff line number Diff line change
Expand Up @@ -90,7 +90,12 @@ func (va *ValidationAuthorityImpl) IsCAAValid(ctx context.Context, req *vapb.IsC
}

internalErr = va.checkCAA(ctx, acmeID, params)

// Stop the clock for local check latency.
localLatency = va.clk.Since(start)

if internalErr != nil {
logEvent.InternalError = internalErr.Error()
prob = detailedError(internalErr)
prob.Detail = fmt.Sprintf("While processing CAA for %s: %s", req.Domain, prob.Detail)
} else if remoteCAAResults != nil {
Expand Down

0 comments on commit 65de9fb

Please sign in to comment.