Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wfe2: Check nonce length #7045

Merged
merged 6 commits into from
Aug 22, 2023

Conversation

pgporada
Copy link
Member

@pgporada pgporada commented Aug 21, 2023

Performs a bounds check in nonceWellFormed to prevent a slice bounds out of range error.

@pgporada pgporada requested a review from a team as a code owner August 21, 2023 16:10
wfe2/verify_test.go Outdated Show resolved Hide resolved
wfe2/verify_test.go Outdated Show resolved Hide resolved
wfe2/verify.go Outdated Show resolved Hide resolved
@pgporada pgporada requested review from beautifulentropy and a team August 21, 2023 17:16
@pgporada pgporada requested a review from a team August 21, 2023 17:17
@beautifulentropy
Copy link
Member

Great work, thanks for getting this fix out so quickly!

@pgporada pgporada requested a review from a team August 21, 2023 18:02
@aarongable aarongable merged commit e7f7829 into main Aug 22, 2023
21 checks passed
@aarongable aarongable deleted the check-that-nonce-size-is-greater-than-prefixlen branch August 22, 2023 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants