-
-
Notifications
You must be signed in to change notification settings - Fork 608
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename int64 timestamp related protobuf fields to <fieldname>NS #7069
Conversation
…indicate they are Unix nanosecond timestamps
The
|
Agreed. I wouldn't trust the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is looking pretty good! I did a quick search through our various *.proto
files for int64
fields and turned up a few more candidates.
Line 44 in c38efd4
int64 revokedAt = 4; |
Line 52 in c38efd4
int64 revokedDate = 5; |
Line 54 in c38efd4
int64 lastExpirationNagSent = 7; |
Line 55 in c38efd4
int64 notAfter = 9; |
Line 85 in c38efd4
int64 expires = 3; |
Line 92 in c38efd4
int64 created = 10; |
int64 time = 1; // In nanoseconds |
Line 210 in c38efd4
int64 issued = 4; |
Line 235 in c38efd4
int64 expires = 2; |
aa4a50d
* Adds new `google.protobuf.Timestamp` fields to each .proto file where we had been using `int64` fields as a timestamp. * Updates relevant gRPC messages to populate the new `google.protobuf.Timestamp` fields in addition to the old `int64` timestamp fields. * Added tests for each `<x>ToPB` and `PBto<x>` functions to ensure that new fields passed into a gRPC message arrive as intended. * Removed an unused error return from `PBToCert` and `PBToCertStatus` and cleaned up each call site. Built on-top of #7069 Part 2 of 4 related to #7060
Rename all of int64 timestamp fields to
<fieldname>NS
to indicate they are Unix nanosecond timestamps.Part 1 of 4 related to #7060