Greatly simplify crl-updater's batch mode #7079
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aarongable
force-pushed
the
crl-simpler-batch
branch
from
ecfe969 to
74ab228
Compare
jsha
previously approved these changes
Sep 18, 2023
beautifulentropy
requested changes
Sep 19, 2023
pgporada
approved these changes
Sep 19, 2023
beautifulentropy
approved these changes
Sep 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace crl-updater's overly complex RunOnce and updateIssuer methods with a single, much simpler RunOnce that is modeled off of the recently-redone continuous Run method's model. Instead of breaking things down by issuer then shard, simply kick off everything in parallel. This also improves batch mode's ability to listen for context cancellations at all the appropriate times.
At the same time, move getShardMappings into the shared updater.go file because it is used by both the batch and continuous modes of operation, and improve uniformity of usage of the crlId structure in log output.
Fixes #7066
DO NOT MERGE before #7078