Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix flaky test failure from the inexorable forward march of time #7090

Merged
merged 1 commit into from
Sep 18, 2023

Conversation

aarongable
Copy link
Contributor

@aarongable aarongable commented Sep 18, 2023

People assume that time is a strict progression of cause to effect, but actually, from a nonlinear, non-subjective viewpoint, it's more like a big ball of wibbly-wobbly, timey-wimey... stuff.

@aarongable aarongable requested a review from a team as a code owner September 18, 2023 20:53
@aarongable aarongable requested a review from jsha September 18, 2023 20:53
Copy link
Contributor

@jsha jsha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Quibble: this bug would also exist if time inexorably marched in a circle, or wibbled back and forth.

@aarongable
Copy link
Contributor Author

My apologies, PR description updated. Test-only, merging on one review.

@aarongable aarongable merged commit 6ce2ee3 into main Sep 18, 2023
12 checks passed
@aarongable aarongable deleted the timing branch September 18, 2023 21:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants