Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wfe: orders link to authz IDs with acccount #7790

Merged
merged 2 commits into from
Nov 15, 2024
Merged

Conversation

jsha
Copy link
Contributor

@jsha jsha commented Nov 7, 2024

This means that most traffic will go to the authz URLs with account. After this has been deployed for 30 days (the max lifetime of an order), we can remove support for the old paths.

Part of #7683

DO NOT MERGE until a release containing #7768 has been deployed.

@jsha jsha requested a review from a team as a code owner November 7, 2024 00:01
@jsha jsha requested a review from aarongable November 7, 2024 00:01
@jsha
Copy link
Contributor Author

jsha commented Nov 7, 2024

Getting this test failure:

    otel_test.go:248: Failed to find expected spans in Jaeger for trace 2409bf2a10a1931b442489ff9943345d

aarongable
aarongable previously approved these changes Nov 8, 2024
Copy link
Contributor

@aarongable aarongable left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Getting this test failure:

I think the more descriptive error message is a few lines up:

did not find span boulder-wfe2::/acme/authz-v3/ with parent 'a089a8b134d40eaa'

The trace test in otel_test is looking for a request to a path under /authz-v3/ specifically. I think the fix is just

--- a/test/integration/otel_test.go
+++ b/test/integration/otel_test.go
@@ -222,7 +222,7 @@ func TestTraces(t *testing.T) {
                        httpSpan("/acme/new-acct",
                                redisPipelineSpan("get", wfe)),
                        httpSpan("/acme/new-order"),
-                       httpSpan("/acme/authz-v3/"),
+                       httpSpan("/acme/authz/"),
                        httpSpan("/acme/chall-v3/"),
                        httpSpan("/acme/finalize/",

@aarongable aarongable merged commit 56f0ed6 into main Nov 15, 2024
12 checks passed
@aarongable aarongable deleted the default-to-regid-in-path branch November 15, 2024 18:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants