-
-
Notifications
You must be signed in to change notification settings - Fork 608
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
va: prepare to require minimum of 3 RVAs #7815
Conversation
Previously this was a configuration field.
@jsha, this PR appears to contain configuration and/or SQL schema changes. Please ensure that a corresponding deployment ticket has been filed with the new values. |
The base branch was changed.
One particular change to note with the merge: the |
To prepare for the MPIC requirement of having a minimum of 3 perspectives, I added code to
NewValidationAuthorityImpl
to error if there aren't enough remote VAs configured and the current VA is the primary perspective. Then I fixed all the tests, which involved adding some backends in the unittests, and spinning upremoteva-c
in the integration tests.As a reminder, the
boulder va
command always considers itself the primary perspective, whileboulder remoteva
gives itself a perspective based on its config.I wound up backing out the code in
NewValidationAuthorityImpl
because right now our remote VAs are actually running theboulder va
command, so they would error out in prod, even though our actual primary perspective does have enough backends. So this wound up as a test-only change.