Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

va: prepare to require minimum of 3 RVAs #7815

Merged
merged 26 commits into from
Nov 19, 2024
Merged

va: prepare to require minimum of 3 RVAs #7815

merged 26 commits into from
Nov 19, 2024

Conversation

jsha
Copy link
Contributor

@jsha jsha commented Nov 14, 2024

To prepare for the MPIC requirement of having a minimum of 3 perspectives, I added code to NewValidationAuthorityImpl to error if there aren't enough remote VAs configured and the current VA is the primary perspective. Then I fixed all the tests, which involved adding some backends in the unittests, and spinning up remoteva-c in the integration tests.

As a reminder, the boulder va command always considers itself the primary perspective, while boulder remoteva gives itself a perspective based on its config.

I wound up backing out the code in NewValidationAuthorityImpl because right now our remote VAs are actually running the boulder va command, so they would error out in prod, even though our actual primary perspective does have enough backends. So this wound up as a test-only change.

@jsha jsha requested a review from a team as a code owner November 14, 2024 23:51
@jsha jsha requested review from aarongable and removed request for a team November 14, 2024 23:51
Copy link
Contributor

@jsha, this PR appears to contain configuration and/or SQL schema changes. Please ensure that a corresponding deployment ticket has been filed with the new values.

cmd/boulder-va/main.go Outdated Show resolved Hide resolved
test/v2_integration.py Outdated Show resolved Hide resolved
va/va_test.go Outdated Show resolved Hide resolved
aarongable
aarongable previously approved these changes Nov 15, 2024
Base automatically changed from va-maxremotefailures-mpic to main November 18, 2024 23:36
@jsha jsha dismissed stale reviews from beautifulentropy and aarongable November 18, 2024 23:36

The base branch was changed.

@jsha
Copy link
Contributor Author

jsha commented Nov 19, 2024

One particular change to note with the merge: the Local VA ok, 1/2 remote VA internal err test case is removed (even though it was just added) because it no longer makes sense to have only 2 remote VAs. The primary VA would error at construction time.

@beautifulentropy beautifulentropy merged commit 577a1e3 into main Nov 19, 2024
12 checks passed
@beautifulentropy beautifulentropy deleted the min-3-rvas branch November 19, 2024 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants