ra: temporarily remove flaky test

[jsha]

This test is flaking a lot on main. We'll restore it soon but in the meantime we shouldn't have flaky tests.

We'll use #7812 to track re-adding this test.

[jsha]

Got an integration test failure:

--- FAIL: TestCertificatesPerDomain (2.36s)
    ratelimit_test.go:57: Somehow managed to issue third certificate: expected error but received none
FAIL
FAIL	github.com/letsencrypt/boulder/test/integration	32.988s
FAIL

I suspect this is also a flake and I'm re-running that CI task now.

[beautifulentropy]

Got an integration test failure:

--- FAIL: TestCertificatesPerDomain (2.36s)
    ratelimit_test.go:57: Somehow managed to issue third certificate: expected error but received none
FAIL
FAIL	github.com/letsencrypt/boulder/test/integration	32.988s
FAIL

I suspect this is also a flake and I'm re-running that CI task now.

I think the fix is to make this call synchronous:

boulder/ra/ra.go

Line 1361 in 2502113

go ra.countCertificateIssued(ctx, int64(acctID), slices.Clone(parsedCertificate.DNSNames), isRenewal)

[beautifulentropy]

Similarly to what I've noted on countCertificateIssued. I think the fix for this is to make countValidationsFailed synchronous:

boulder/ra/ra.go

Lines 2001 to 2006 in 2502113

	go func() {
	err := ra.countFailedValidations(vaCtx, authz.RegistrationID, authz.Identifier)
	if err != nil {
	ra.log.Warningf("incrementing failed validations: %s", err)
	}
	}()

[jsha]

Ooh excellent catch! I'll try that instead.

[beautifulentropy]

Ooh excellent catch! I'll try that instead.

I would sign off on fixing both in this PR 👍🏻

[beautifulentropy]

As we discussed offline, closing in favour of: #7824