va: Make the primary VA aware of the Perspective and RIR of each remote #7839
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
beautifulentropy
force-pushed
the
trust-but-verify
branch
3 times, most recently
from
a68fa53
to
0d9ba2a
Compare
beautifulentropy
changed the title
beautifulentropy
changed the title
beautifulentropy
changed the title
beautifulentropy
force-pushed
the
trust-but-verify
branch
from
0d9ba2a
to
315fc11
Compare
beautifulentropy
force-pushed
the
trust-but-verify
branch
from
315fc11
to
18c6f83
Compare
|
@beautifulentropy, this PR appears to contain configuration and/or SQL schema changes. Please ensure that a corresponding deployment ticket has been filed with the new values. |
beautifulentropy
changed the title
aarongable
reviewed
Nov 22, 2024
jprenken
approved these changes
Nov 22, 2024
aarongable
approved these changes
Nov 25, 2024
| // ServerAddress, DNSAuthority, [Timeout], [HostOverride] | ||
| // SRVLookup, DNSAuthority, [Timeout], [HostOverride], [SRVResolver] | ||
| // SRVLookups, DNSAuthority, [Timeout], [HostOverride], [SRVResolver] | ||
| type RemoteVAGRPCClientConfig struct { |
There was a problem hiding this comment.
Technically I don't think this type has to be Exported anymore -- only its fields have to be public for parsing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #7819
Updated IN-10231 and created IN-10840.